Refactor Int Types #4061
Closed
Refactor Int Types #4061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheNormalnij
reviewed
Mar 6, 2025
| typedef unsigned short ushort; // 16 | ||
| typedef unsigned char uchar; // 8 | ||
| using ulong = unsigned long; // 32 32 64 | ||
| using uint = std::uint32_t; // 32 |
There was a problem hiding this comment.
This change doesn't look safe for x64 server
There was a problem hiding this comment.
This change doesn't look safe for x64 server
In general, everything is fine, if you have accurate thoughts about a possible problem, I will take note.
|
I am not going to merge this because it might cause unforeseen bugs. I would instead welcome PRs that replace usage of these types with types from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.